Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: cherry-pick enforce-mpp to v5.0 #26382

Merged
merged 18 commits into from
Jul 20, 2021
Merged

planner: cherry-pick enforce-mpp to v5.0 #26382

merged 18 commits into from
Jul 20, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jul 20, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

5.0 needs enforce-mpp.

What is changed and how it works?

cherry-pick these prs to 5.0:

  1. planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan #24157 CopTiFlashConcurrencyFactor
  2. [reverted]planner: support set tidb_allow_mpp to 2 or ENFORCE to enforce use mpp mode. #24516 support allow_mpp=2
  3. planner: Revert tidb_allow_mpp modification for downgrade compatibility and add warnings for enforce mpp. #25302 revert 24516 and support tidb_enforce_mpp and add warning
  4. config: add config for tidb_enforce_mpp and remove the global scope of it. #25369 add config
  5. planner: enforce projection push down #25450 enforce projection push down
  6. planner: Log warnings when agg function can not be pushdown in explain statement #25553 fix warning
  7. planner: add warnings about joins when tidb_enforce_mpp is enabled. #26246 add warning of join

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • Support set tidb_enforce_mpp=1 to enforce use mpp mode.

@LittleFall LittleFall requested review from a team as code owners July 20, 2021 10:15
@LittleFall LittleFall requested review from wshwsh12 and eurekaka and removed request for a team July 20, 2021 10:15
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 20, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@LittleFall
Copy link
Contributor Author

/run-check_release_note

@LittleFall
Copy link
Contributor Author

/cc @fzhedu @hanfei1991

@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall removed sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 20, 2021
@LittleFall
Copy link
Contributor Author

/merge

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 20, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 20, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall removed sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 20, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b44ab7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@hanfei1991
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 20, 2021
@ti-chi-bot ti-chi-bot merged commit f5bf404 into pingcap:release-5.0 Jul 20, 2021
@LittleFall LittleFall deleted the cherrypick/enforce-mpp2 branch July 20, 2021 13:21
@LittleFall LittleFall mentioned this pull request Jul 21, 2021
Closed
10 tasks
@LittleFall LittleFall mentioned this pull request Sep 2, 2021
Closed
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
@djshow832 djshow832 mentioned this pull request Sep 15, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@fzhedu fzhedu fzhedu approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/config sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
7 participants
@LittleFall @ti-srebot @ti-chi-bot @fzhedu @hanfei1991 @zhouqiang-cl @windtalker